-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
litra 3.1.0 (new formula) #263407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
litra 3.1.0 (new formula) #263407
Conversation
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
de751ea to
ac6985c
Compare
e65e6d8 to
ef6e225
Compare
This introduces a new formula, `litra`, from the [`timrogers/litra-rs`][1] repository. `litra` is a lightweight command line tool for controlling Logitech Litra key lights. I believe it meets the criteria to be included in Homebrew since it is stable, maintainable, known (113 stars and an active OSS community), used by someone other than the author and it has a homepage. [1]: https://docs.brew.sh/Formula-Cookbook#commit
|
@botantony @SMillerDev I've addressed the feedback now and the build is passing. Thanks for your 👀 ! |
| end | ||
|
|
||
| test do | ||
| assert_match "No Logitech Litra devices found", shell_output("#{bin}/litra devices").strip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| assert_match "No Logitech Litra devices found", shell_output("#{bin}/litra devices").strip | |
| assert_match version.to_s, shell_output("#{bin}/litra --version") | |
| assert_match "No Logitech Litra devices found", shell_output("#{bin}/litra devices") |
| depends_on "hidapi" | ||
| depends_on "openssl@3" | ||
| depends_on "systemd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this patch, we can update to use system dep
| depends_on "hidapi" | |
| depends_on "openssl@3" | |
| depends_on "systemd" | |
| depends_on "hidapi" |
$ brew linkage litra
System libraries:
/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2
/lib/x86_64-linux-gnu/libc.so.6
/lib/x86_64-linux-gnu/libgcc_s.so.1
/lib/x86_64-linux-gnu/libm.so.6
Homebrew libraries:
/home/linuxbrew/.linuxbrew/opt/hidapi/lib/libhidapi-hidraw.so.0 (hidapi)
This introduces a new formula,
litra, from thetimrogers/litra-rsrepository.litrais a lightweight command line tool for controlling Logitech Litra key lights.I believe it meets the criteria to be included in Homebrew since it is stable, maintainable, known (113 stars and an active OSS community), used by someone other than the author and it has a homepage.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?