fix(drawer): address rendering issue with drawer and sub-navigation #5792
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or prefers-reduced-motion users
github-project-automation
bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
🦋 Changeset detectedLatest commit: cb378e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
📕documentation
nmerget
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
mfranzke
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a rendering issue where the drawer component and sub-navigation were not properly positioned for users with prefers-reduced-motion: reduce accessibility preference. When animations are disabled for accessibility, the drawer was appearing off-screen instead of in its final visible position.
Changes:
- Added explicit transform rules for
prefers-reduced-motion: reducemedia query to ensure drawer is properly positioned - Updated changeset to document the accessibility fix across all framework packages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/src/components/drawer/drawer.scss | Added prefers-reduced-motion: reduce media query block that sets appropriate transforms to position drawer correctly when animations are disabled |
| .changeset/loose-nails-shine.md | Added changeset documenting the bug fix for all affected framework packages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix(drawer): address rendering issue with drawer and sub-navigation for
prefers-reduced-motionusersTypes of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-drawer-sub-navigation-reduced-motion