Skip to content

[browser] LoopbackServer - make GenericLoopbackServer.CloseWebSocket async #123327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pavelsavara wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[browser] LoopbackServer - make GenericLoopbackServer.CloseWebSocket async #123327

pavelsavara wants to merge 2 commits into from
+27 −34

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 18, 2026

  • stop calling blocking Task.WaitAll on browser - it throws PNSE
  • make the method async, rename it and fix all call sites

@pavelsavara pavelsavara added this to the 11.0.0 milestone Jan 18, 2026
@pavelsavara pavelsavara self-assigned this Jan 18, 2026
@pavelsavara pavelsavara added area-System.Net.Http os-browser Browser variant of arch-wasm labels Jan 18, 2026
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jan 18, 2026

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara requested a review from maraf January 18, 2026 17:49
This was referenced Jan 18, 2026
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maraf maraf Awaiting requested review from maraf

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels

area-System.Net.Http os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@pavelsavara