Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Jan 18, 2026

Breaking #21025 to smaller chunks. This PR adds a new test function, setting up the etcd with PUTs and asserting the expected results with two basic test cases:

  • GET a single key without any options
  • GET a single key with serializable options.

@serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nwnt
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nwnt nwnt force-pushed the add-range-test-with-header branch from 6173a39 to 9e24f84 Compare January 18, 2026 05:45
@nwnt nwnt force-pushed the add-range-test-with-header branch from 9e24f84 to 10ddf84 Compare January 18, 2026 05:45
@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.46%. Comparing base (28bed68) to head (11dcfb2).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21152      +/-   ##
==========================================
+ Coverage   68.36%   68.46%   +0.10%     
==========================================
  Files         429      429              
  Lines       35267    35267              
==========================================
+ Hits        24110    24146      +36     
+ Misses       9763     9731      -32     
+ Partials     1394     1390       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28bed68...11dcfb2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
}

func TestKVGetWithHeader(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having separate Test will not make removal of the original test easier to review

@serathius
Copy link
Member

One way to split PR is to extract response validation but not change test cases, for example main...serathius:etcd:test-range-response

@nwnt nwnt force-pushed the add-range-test-with-header branch from 10ddf84 to adaa696 Compare January 18, 2026 21:39
@nwnt nwnt force-pushed the add-range-test-with-header branch from adaa696 to 12dc2b1 Compare January 18, 2026 21:42
@nwnt nwnt force-pushed the add-range-test-with-header branch from 12dc2b1 to 11dcfb2 Compare January 18, 2026 21:43
@nwnt
Copy link
Member Author

nwnt commented Jan 18, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants