-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add range test with header #21152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add range test with header #21152
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nwnt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6173a39 to
9e24f84
Compare
9e24f84 to
10ddf84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 18 files with indirect coverage changes @@ Coverage Diff @@
## main #21152 +/- ##
==========================================
+ Coverage 68.36% 68.46% +0.10%
==========================================
Files 429 429
Lines 35267 35267
==========================================
+ Hits 24110 24146 +36
+ Misses 9763 9731 -32
+ Partials 1394 1390 -4 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
tests/common/kv_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestKVGetWithHeader(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having separate Test will not make removal of the original test easier to review
|
One way to split PR is to extract response validation but not change test cases, for example main...serathius:etcd:test-range-response |
10ddf84 to
adaa696
Compare
adaa696 to
12dc2b1
Compare
Signed-off-by: Nont <[email protected]>
12dc2b1 to
11dcfb2
Compare
|
/retest |
Breaking #21025 to smaller chunks. This PR adds a new test function, setting up the etcd with PUTs and asserting the expected results with two basic test cases:
@serathius