Skip to content

C++: Generate IR for assertions in release builds #21142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MathiasVP wants to merge 8 commits into
base: main
Choose a base branch
from
Open

C++: Generate IR for assertions in release builds #21142

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6e3fd25
C++: Add tests for assertions in release builds.
MathiasVP Jan 9, 2026
67ab0fe
C++: Add a few helper predicates.
MathiasVP Jan 9, 2026
a18f3b6
C++: Avoid generating IR for a few cases where we will be synthesizin…
MathiasVP Jan 9, 2026
aa058c2
C++: Generate IR for assertions in release builds.
MathiasVP Jan 9, 2026
4f4baee
C++: Fix Code Scanning alerts.
MathiasVP Jan 9, 2026
d6ca1ca
Update cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/Tran…
MathiasVP Jan 15, 2026
1b11790
Update cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/Tran…
MathiasVP Jan 15, 2026
03d6528
Update cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/Tran…
MathiasVP Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cpp/ql/lib/semmle/code/cpp/Element.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,11 @@ class Element extends ElementBase {
*/
predicate isAffectedByMacro() { affectedByMacro(this) }

/** Holds if this element is affected by the expansion of `mi`. */
predicate isAffectedByMacro(MacroInvocation mi) {
affectedbymacroexpansion(underlyingElement(this), unresolveElement(mi))
}
Comment on lines +195 to +198
Copy link
Contributor

@jketema jketema Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this might be potentially confusing, because isAffectedByMacro/0 is not implemented as affectedbymacroexpansion(underlyingElement(this), _).

Copy link
Contributor Author

@MathiasVP MathiasVP Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Do you have any suggestion for a better QLDoc?

Copy link
Contributor

@jketema jketema Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can change both implementations to something along the following lines (in a separate PR if this is actually possible):

affectedbymacroexpansion(e, mi) or inmacroexpansion(e, mi)


private Element getEnclosingElementPref() {
enclosingfunction(underlyingElement(this), unresolveElement(result)) or
result.(Function) = stmtEnclosingElement(this) or
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/lib/semmle/code/cpp/exprs/Expr.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Expr extends StmtParent, @expr {
predicate hasChild(Expr e, int n) { e = this.getChild(n) }

/** Gets the enclosing function of this expression, if any. */
Function getEnclosingFunction() { result = exprEnclosingElement(this) }
override Function getEnclosingFunction() { result = exprEnclosingElement(this) }

/** Gets the nearest enclosing set of curly braces around this expression in the source, if any. */
BlockStmt getEnclosingBlock() { result = this.getEnclosingStmt().getEnclosingBlock() }
Expand Down
14 changes: 13 additions & 1 deletion cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/InstructionTag.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ newtype TInstructionTag =
} or
SizeofVlaDimensionTag(int index) {
exists(VlaDeclStmt v | exists(v.getTransitiveVlaDimensionStmt(index)))
}
} or
AssertionVarAddressTag() or
AssertionVarLoadTag() or
AssertionOpTag() or
AssertionBranchTag()

class InstructionTag extends TInstructionTag {
final string toString() { result = getInstructionTagId(this) }
Expand Down Expand Up @@ -296,4 +300,12 @@ string getInstructionTagId(TInstructionTag tag) {
tag = CoAwaitBranchTag() and result = "CoAwaitBranch"
or
tag = BoolToIntConversionTag() and result = "BoolToIntConversion"
or
tag = AssertionVarAddressTag() and result = "AssertionVarAddress"
or
tag = AssertionVarLoadTag() and result = "AssertionVarLoad"
or
tag = AssertionOpTag() and result = "AssertionOp"
or
tag = AssertionBranchTag() and result = "AssertionBranch"
}
Loading