-
Notifications
You must be signed in to change notification settings - Fork 37.5k
Hide slash commands from chatSessions participants in global chat menu #288475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For chatSessions contributed chat participants (isDynamic agents), we now hide their slash commands from the global menu unless the user is actively talking with that participant. The agent itself can still be selected via @mention, and once selected, their slash commands will be available. Co-authored-by: joshspicer <[email protected]>
|
@copilot 'isDynamic' is a bit too broad - we instead need to check if it's a chatSessions contribution with one of the chatSessions helpers |
Changed from using agent.isDynamic to using chatSessionsService.getChatSessionContribution(agent.id) to specifically check for chatSessions contributions rather than filtering all dynamic agents. Co-authored-by: joshspicer <[email protected]>
Updated in 6f66616 to use |
|
@copilot seems like it may be more efficient to filter out the relevant chatSession-contrbuted agents ahead of time? What do you think? |
Moved the chatSessions contribution check to filter agents upfront rather than checking inside each flatMap iteration. This is more efficient as it avoids calling getChatSessionContribution multiple times for each agent's slash commands. Co-authored-by: joshspicer <[email protected]>
Good suggestion. In 47fc606 I moved the filtering to happen upfront rather than inside the flatMap loop. This avoids calling |
Slash commands from
chatSessionscontributed chat participants (e.g.,@claude) were appearing in the global chat completion menu, even when not actively talking with that participant.Changes
chatSessionsService.getChatSessionContribution(agent.id)inchatInputCompletions.tsIChatSessionsServicedependency injection toAgentCompletionsclass@trigger (shows@agent /command)/trigger (shows/command @agent)chatAgentSubcommandprovider—once a user selects@claude, their slash commands still appear as expectedOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.