Skip to content

Conversation

@pwang347
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 17, 2026 00:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds an instruction for agents to read the entire SKILL.md file when working with skills. The change modifies the automatic instructions generated for chat agents to emphasize that skill files should be read completely.

Changes:

  • Updated the instruction text in computeAutomaticInstructions.ts to explicitly tell agents to read all of the SKILL.md file when acquiring skill instructions
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/common/promptSyntax/computeAutomaticInstructions.ts:312

  • The phrase "all of the SKILL.md file" is grammatically incorrect. It should be either "the entire SKILL.md file", "all of the file", or "the complete SKILL.md file".
				entries.push(`When a user asks you to perform a task that falls within the domain of a skill, use the ${readTool.variable} tool to acquire the full instructions from the file URI. Make sure to read all of the SKILL.md file.`);

entries.push('Here is a list of skills that contain domain specific knowledge on a variety of topics.');
entries.push('Each skill comes with a description of the topic and a file path that contains the detailed instructions.');
entries.push(`When a user asks you to perform a task that falls within the domain of a skill, use the ${readTool.variable} tool to acquire the full instructions from the file URI.`);
entries.push(`When a user asks you to perform a task that falls within the domain of a skill, use the ${readTool.variable} tool to acquire the full instructions from the file URI. Make sure to read all of the SKILL.md file.`);
Copy link

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instruction text is inconsistent in how it refers to the skill file. The instruction says "acquire the full instructions from the file URI" but then says "read all of the SKILL.md file." This is confusing because:

  1. Not all skill files are named "SKILL.md" - they could be from extensions or other sources
  2. The variable already refers to "the file URI", so adding "the SKILL.md file" creates redundancy
  3. The phrase "all of the SKILL.md file" is grammatically awkward - it should be either "the entire SKILL.md file" or "all of the file"

Consider revising to: "When a user asks you to perform a task that falls within the domain of a skill, use the ${readTool.variable} tool to acquire the full instructions from the file URI. Make sure to read the entire file."

This issue also appears in the following locations of the same file:

  • line 312
Suggested change
entries.push(`When a user asks you to perform a task that falls within the domain of a skill, use the ${readTool.variable} tool to acquire the full instructions from the file URI. Make sure to read all of the SKILL.md file.`);
entries.push(`When a user asks you to perform a task that falls within the domain of a skill, use the ${readTool.variable} tool to acquire the full instructions from the file URI. Make sure to read the entire file.`);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants