Skip to content

src: add missing override specifier to Clean() #61429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tniessen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: add missing override specifier to Clean() #61429

tniessen wants to merge 1 commit into from
+1 −1

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jan 18, 2026

The CallbackInfo::Clean() method overrides Cleanable::Clean() and should be marked as override, both because it is good practice to do so and for consistency with the rest of the code base.

@tniessen
src: add missing override specifier to Clean()
a86ff58 
The `CallbackInfo::Clean()` method overrides `Cleanable::Clean()` and
should be marked as `override`, both because it is good practice to do
so and for consistency with the rest of the code base.
@tniessen tniessen added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 18, 2026
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Jan 18, 2026
@codecov
Copy link

codecov bot commented Jan 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (9bcfbeb) to head (a86ff58).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #61429   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         704      704           
  Lines      208883   208883           
  Branches    40333    40344   +11     
=======================================
+ Hits       184926   184933    +7     
- Misses      15934    15953   +19     
+ Partials     8023     7997   -26
Files with missing lines Coverage Δ
src/node_buffer.cc 68.81% <ø> (ø)

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tniessen @cjihrig @nodejs-github-bot