Skip auto-funding for accounts that were explicitly dealt #496
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkhry
reviewed
Jan 18, 2026
| pub eth_deals: Vec<DealRecord>, | ||
|
|
||
| /// Addresses that have been explicitly funded via `vm.deal()`. | ||
| pub dealt_accounts: HashSet<Address>, |
pkhry
reviewed
Jan 18, 2026
| } | ||
|
|
||
| /// Funds pranked fuzz addresses with u128::MAX so they can make calls in pallet-revive. | ||
| /// Skips accounts that were explicitly dealt to via vm.deal() to preserve balance assertions. |
There was a problem hiding this comment.
what happens if account is nonexistant in pallet-revive and needs a balance/nonce sync? e.g. created from within a self call within a test contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fund_pranked_accounts overwriting dealt account balances.
Track accounts explicitly funded via vm.deal() and skip auto-funding them in fund_pranked_accounts. Previously, pranking an account that had spent its balance to zero would incorrectly set it to u128::MAX, breaking balance assertions in tests.