Skip to content

Conversation

@johnslavik
Copy link
Member

Misc/gdbinit was removed in GH-102854 (3.12.0a7).

@johnslavik johnslavik added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 18, 2026
@johnslavik johnslavik changed the title No longer mention Misc/gdbinit in PyObject_Dump code doc No longer mention Misc/gdbinit in the code Jan 18, 2026
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or fix it like this one was done?

- GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the

@johnslavik
Copy link
Member Author

johnslavik commented Jan 18, 2026

Or fix it like this one was done?

- GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the

I'm not sure. This comment remains on 3.10, 3.11 and 3.12 branches, would including Misc/gdbinit again be helpful?
Or do you mean mentioning GDB 7?
Or do you have in mind some other specific idea of improving this comment?

We could direct the reader to Doc/howto/gdb_helpers.rst maybe?

@StanFromIreland
Copy link
Member

Oh I only have the one line shown, I was referring to: "see Misc/gdbinit in the sources of Python 3.11 or earlier."

@johnslavik
Copy link
Member Author

johnslavik commented Jan 18, 2026

Thanks. Personally, I don't find it necessary, because the 3.11 and earlier branches still will include the mention of Misc/gdbinit after we merge this.

@StanFromIreland
Copy link
Member

Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no?

@johnslavik
Copy link
Member Author

Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no?

I was thinking that mentioning Misc/gdbinit would not be useful to people on branches that don't contain the file, because they wouldn't need nor be able to use the file.

If they needed to debug 3.11, they would check it out and the comment would be there.
Unless I am missing something?

@johnslavik
Copy link
Member Author

Do you have an example of when this is useful for someone debugging in the 3.13-3.15 branches only?

@ZeroIntensity
Copy link
Member

Yeah, I agree with Bartosz here. The mention in the docs was added after Misc/gdbinit was removed, so I think it's intentional to keep that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants